Forum archive

parameters are skipped + correction of the source

Return to forum index

• AlgorithMan at 2005-02-27 00:29
  in the current release of jfduke3d you can't pass commandline parameters starting with "/". I think the error is that the while-loop is continued at the marked line - if it wasn't continued, argv could be checked later...
  
  game.c
  
  

  
  
  while(i < argc) 
  
     { 
  
     c = argv[i]; 
  
     if (((*c == '/') || (*c == '-')) && (!firstnet)) 
  
        { 
  
     if (!Bstrcasecmp(c+1,"net")) 
  
           { 
  
        firstnet = i; 
  
        netparamcount = argc - i - 1; 
  
        netparam = (char **)calloc(netparamcount, sizeof(char**)); 
  
           } 
  
        i++;                      
  
        continue;                //     <------------- I THINK HERE IS THE ERROR 
  
        } 
  
  
  
     if (firstnet > 0) 
  
        { 
  
        if (*c == '-' || *c == '/') 
  
           { 
  
           c++; 
  
           if (((c[0] == 'n') || (c[0] == 'N')) && (c[1] == '0')) 
  
              { 
  
              networkmode = 0; 
  
              initprintf("Network mode: master/slave\n"); 
  
              } 
  
           else 
  
              if (((c[0] == 'n') || (c[0] == 'N')) && (c[1] == '1')) 
  
                 { 
  
                 networkmode = 1; 
  
                 initprintf("Network mode: peer-to-peer\n"); 
  
                 } 
  
           } 
  
        netparam[i-firstnet-1] = argv[i]; 
  
        i++; 
  
        continue; 
  
        } 
  
  
  
     // HERE THE USUAL COMMANDS ARE PARSED 
  
  
  
     i++; 
  
     }  
  
  

• Nxskingdom at 2005-02-27 03:09
  So how do you think you can fix it? :)
• AlgorithMan at 2005-02-27 09:55
  easy: delete the "i++;" and the "continue;" there =)
• Nxskingdom at 2005-02-27 10:46
  ha ok :)
  
  I wasn't too sure if something else was in fault.
• TX at 2005-02-27 12:42

  easy: delete the "i++;" and the "continue;" there =)

  Uh, actually, to fix the problem you'd need to move them into the set of braces closed directly above them. The problem has been fixed another way for the next release, however. Your simple deletion "fix" would likely fuck everything up as the network parameters would end up being fed into the normal command line processor, giving you a lovely command line help dialog every time you attempted to play multiplayer.
• AlgorithMan at 2005-02-27 21:16
  yes, you are right - but I'm not sure if it wouldn't work without these lines either...